Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark and Duplex Pipe Concurrent Usage Fixes #27

Merged
merged 15 commits into from
Sep 17, 2023

Conversation

DJGosnell
Copy link
Member

@DJGosnell DJGosnell commented Sep 13, 2023

Pipes

  • Major Rework of internal pipes but no public API changes. We kept running into issues with pipes once returned to the cache would still have outstanding references and cancellations would sometimes cross pipe instance barriers. This PR removed caching and all pipes are now created for each pipe usage. This creates a little memory pressure, but we can re-evaluate this later. Possibly caching the reader and writers instead of the whole NexusDuplexPipe.
  • Fixed longstanding issue with cancellation of PipeReader under certain high concurrency circumstances.

Benchmarks

  • Created benchmarks for common scenarios.
  • Added benchmarks to readme

Misc

  • Fixed miscellaneous tests which failed due to concurrent counting.

@DJGosnell DJGosnell merged commit a289d03 into master Sep 17, 2023
1 check passed
@DJGosnell DJGosnell deleted the benchmark-and-duplex-pipe-fixes branch September 17, 2023 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant